【fix sonar】 JobAlarmer.java文件

This commit is contained in:
tianwenbo
2023-03-10 13:56:16 +08:00
parent 28ef6b0c82
commit 3a1c15fe63
@@ -29,8 +29,8 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean {
@Override
public void afterPropertiesSet() throws Exception {
Map<String, JobAlarm> serviceBeanMap = applicationContext.getBeansOfType(JobAlarm.class);
if (serviceBeanMap != null && serviceBeanMap.size() > 0) {
jobAlarmList = new ArrayList<JobAlarm>(serviceBeanMap.values());
if (!serviceBeanMap.isEmpty()) {
jobAlarmList = new ArrayList<>(serviceBeanMap.values());
}
}
@@ -44,7 +44,7 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean {
public boolean alarm(XxlJobInfo info, XxlJobLog jobLog) {
boolean result = false;
if (jobAlarmList!=null && jobAlarmList.size()>0) {
if (jobAlarmList!=null && !jobAlarmList.isEmpty()) {
result = true; // success means all-success
for (JobAlarm alarm: jobAlarmList) {
boolean resultItem = false;