From 3a1c15fe638b3ac2bda10fb85b8a7e26fb1ab9ab Mon Sep 17 00:00:00 2001 From: tianwenbo Date: Fri, 10 Mar 2023 13:56:05 +0800 Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91=20JobAlarmer.java?= =?UTF-8?q?=E6=96=87=E4=BB=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java index 797dc900..addeb2e3 100644 --- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java +++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java @@ -29,8 +29,8 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean { @Override public void afterPropertiesSet() throws Exception { Map serviceBeanMap = applicationContext.getBeansOfType(JobAlarm.class); - if (serviceBeanMap != null && serviceBeanMap.size() > 0) { - jobAlarmList = new ArrayList(serviceBeanMap.values()); + if (!serviceBeanMap.isEmpty()) { + jobAlarmList = new ArrayList<>(serviceBeanMap.values()); } } @@ -44,7 +44,7 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean { public boolean alarm(XxlJobInfo info, XxlJobLog jobLog) { boolean result = false; - if (jobAlarmList!=null && jobAlarmList.size()>0) { + if (jobAlarmList!=null && !jobAlarmList.isEmpty()) { result = true; // success means all-success for (JobAlarm alarm: jobAlarmList) { boolean resultItem = false;