diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java index 797dc900..addeb2e3 100644 --- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java +++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/alarm/JobAlarmer.java @@ -29,8 +29,8 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean { @Override public void afterPropertiesSet() throws Exception { Map serviceBeanMap = applicationContext.getBeansOfType(JobAlarm.class); - if (serviceBeanMap != null && serviceBeanMap.size() > 0) { - jobAlarmList = new ArrayList(serviceBeanMap.values()); + if (!serviceBeanMap.isEmpty()) { + jobAlarmList = new ArrayList<>(serviceBeanMap.values()); } } @@ -44,7 +44,7 @@ public class JobAlarmer implements ApplicationContextAware, InitializingBean { public boolean alarm(XxlJobInfo info, XxlJobLog jobLog) { boolean result = false; - if (jobAlarmList!=null && jobAlarmList.size()>0) { + if (jobAlarmList!=null && !jobAlarmList.isEmpty()) { result = true; // success means all-success for (JobAlarm alarm: jobAlarmList) { boolean resultItem = false;