代码审查

jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/system/service/impl/SysDictServiceImpl.java

@@ -382,6 +382,7 @@ public class SysDictServiceImpl extends ServiceImpl<SysDictMapper, SysDict> impl
 		Integer count = sysDictMapper.selectCount(queryWrapper);
 		return count;
 	}
+	//TODO 代码加注释
 	@Override
 	public Integer queryExitDictName(SysDict sysDict) {
 		LambdaQueryWrapper<SysDict> queryWrapper = new LambdaQueryWrapper<>();

jero-boot/jero-boot-modules/src/main/java/com/jero/modules/document/service/impl/BussDocumentLibraryEOServiceImpl.java

@@ -296,6 +296,7 @@ public class BussDocumentLibraryEOServiceImpl extends ServiceImpl<BussDocumentLi
         //字段属性
         List<OnlCgformField> fieldList = onlCgformFieldService.getFieldList(flag);
         //过滤出字段为树形结构的
+        //TODO 未使用的删掉就完了
         List<OnlCgformField> onlCgformFieldTree = fieldList.stream().filter(e -> FieldTypeEnum.TREE.getValue().equals(e.getFieldShowType())).collect(Collectors.toList());
 
         if (fieldList.size() != 0) {
@@ -680,6 +681,7 @@ public class BussDocumentLibraryEOServiceImpl extends ServiceImpl<BussDocumentLi
         //字段属性
         List<OnlCgformField> fieldList = onlCgformFieldService.getFieldList(ModuleEnum.DOCUMENT_LIBRARY.getValue());
         //时间类型字段
+        //TODO 未被使用删除即可
         List<OnlCgformField> fieldDateList = fieldList.stream().filter(e -> FieldTypeEnum.DATE_SINGLE.getValue().equals(e.getFieldShowType())).collect(Collectors.toList());
         //文件类型字段
         List<OnlCgformField> fieldFileList = fieldList.stream().filter(e -> FieldTypeEnum.FILE.getValue().equals(e.getFieldShowType())).collect(Collectors.toList());
@@ -815,6 +817,7 @@ public class BussDocumentLibraryEOServiceImpl extends ServiceImpl<BussDocumentLi
         StringBuilder fieldsBuilder = new StringBuilder();
         //数据值
         StringBuilder valuesBuilder = new StringBuilder();
+        //TODO 未被使用删除即可
         SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
         for (Map.Entry<String, Object> entry : map.entrySet()) {
             String key = entry.getKey();
@@ -941,6 +944,7 @@ public class BussDocumentLibraryEOServiceImpl extends ServiceImpl<BussDocumentLi
         //文件类型的字段
         List<String> fieldFile = fieldFileList.stream().map(OnlCgformField::getDbFieldName).collect(Collectors.toList());
         //下拉类型的字段
+        //TODO 未被使用删除即可
         List<String> fieldPull = fieldPullList.stream().map(OnlCgformField::getDbFieldName).collect(Collectors.toList());
         //过滤出树形字段
         List<OnlCgformField> treeFieldList = fieldList.stream()

jero-boot/jero-boot-modules/src/main/java/com/jero/modules/tag/controller/OnlCgformTagController.java

@@ -103,6 +103,7 @@ public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgf
 			return Result.error("固定字段,不可修改");
 		}else {
 			onlCgformTagService.editById(onlCgformTag);
+			//TODO 统一定义枚举或者统一常量形式并且加注释说明，不然ID写的太乱后期不好修改
 			onlCgformApiController.h("48308196e7b04761b533dc31bc899707","normal");
 			return Result.OK("编辑成功！");
 		}
@@ -126,6 +127,7 @@ public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgf
 				result.error500("固定字段,不可删除");
 			} else {
 				onlCgformTagService.deleteById(id);
+				//TODO 统一定义枚举或者统一常量形式并且加注释说明，不然ID写的太乱后期不好修改
 				onlCgformApiController.h("48308196e7b04761b533dc31bc899707","normal");
 				result.OK("删除成功！");
 			}
@@ -149,6 +151,7 @@ public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgf
 			return Result.error("固定字段,不可删除");
 		}else {
 			this.onlCgformTagService.deleteByIds(Arrays.asList(ids.split(",")));
+			//TODO 统一定义枚举或者统一常量形式并且加注释说明，不然ID写的太乱后期不好修改
 			onlCgformApiController.h("48308196e7b04761b533dc31bc899707","normal");
 			return Result.OK("批量删除成功！");
 		}

jero-boot/jero-boot-modules/src/main/java/com/jero/modules/tag/service/impl/OnlCgformTagServiceImpl.java

@@ -58,6 +58,7 @@ public class OnlCgformTagServiceImpl extends ServiceImpl<OnlCgformTagMapper, Onl
 			String pinYin = HanYuPinYinUtil.changeToNumberPinYin(onlCgformTag.getDbFieldTxt());
 			onlCgformTag.setDbFieldName(pinYin.replace(" ","_"));
 			onlCgformTag.setDbFieldEnName(onlCgformTag.getDbFieldEnName().replace(" ","_"));
+			//TODO  使用枚举形式，不能直接使用字符串定义，看不出代表什么含义
 			if(onlCgformTag.getFieldShowType()=="2"){
 				onlCgformTag.setDbType("int");
 			}else if(onlCgformTag.getFieldShowType()=="5" && onlCgformTag.getFieldShowType()=="6"){