【fix sonar】 SysAnnouncementServiceImpl.java文件

This commit is contained in:
tianwenbo
2023-03-07 09:05:44 +08:00
parent 9cff1276ee
commit c9931dc087
@@ -32,10 +32,10 @@ public class SysAnnouncementServiceImpl extends ServiceImpl<SysAnnouncementMappe
@Resource
private SysAnnouncementMapper sysAnnouncementMapper;
@Resource
private SysAnnouncementSendMapper sysAnnouncementSendMapper;
@Transactional
@Override
public void saveAnnouncement(SysAnnouncement sysAnnouncement) {
@@ -59,7 +59,7 @@ public class SysAnnouncementServiceImpl extends ServiceImpl<SysAnnouncementMappe
}
}
}
/**
* @功能:编辑消息信息
*/
@@ -75,11 +75,11 @@ public class SysAnnouncementServiceImpl extends ServiceImpl<SysAnnouncementMappe
String anntId = sysAnnouncement.getId();
Date refDate = new Date();
for(int i=0;i<userIds.length;i++) {
LambdaQueryWrapper<SysAnnouncementSend> queryWrapper = new LambdaQueryWrapper<SysAnnouncementSend>();
LambdaQueryWrapper<SysAnnouncementSend> queryWrapper = new LambdaQueryWrapper<>();
queryWrapper.eq(SysAnnouncementSend::getAnntId, anntId);
queryWrapper.eq(SysAnnouncementSend::getUserId, userIds[i]);
List<SysAnnouncementSend> announcementSends=sysAnnouncementSendMapper.selectList(queryWrapper);
if(announcementSends.size()<=0) {
if(announcementSends.isEmpty()) {
SysAnnouncementSend announcementSend = new SysAnnouncementSend();
announcementSend.setAnntId(anntId);
announcementSend.setUserId(userIds[i]);
@@ -90,7 +90,7 @@ public class SysAnnouncementServiceImpl extends ServiceImpl<SysAnnouncementMappe
}
// 3. 删除多余通知用户数据
Collection<String> delUserIds = Arrays.asList(userIds);
LambdaQueryWrapper<SysAnnouncementSend> queryWrapper = new LambdaQueryWrapper<SysAnnouncementSend>();
LambdaQueryWrapper<SysAnnouncementSend> queryWrapper = new LambdaQueryWrapper<>();
queryWrapper.notIn(SysAnnouncementSend::getUserId, delUserIds);
queryWrapper.eq(SysAnnouncementSend::getAnntId, anntId);
sysAnnouncementSendMapper.delete(queryWrapper);