【fix sonar】RedisServiceImpl文件

This commit is contained in:
梁琦涛
2023-04-04 10:36:36 +08:00
parent a13e2d8e8c
commit 50a0c4cd65
@@ -1,26 +1,19 @@
package com.jero.modules.monitor.service.impl;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Properties;
import javax.annotation.Resource;
import cn.hutool.core.date.DateUtil;
import com.alibaba.fastjson.JSONArray;
import com.alibaba.fastjson.JSONObject;
import com.google.common.collect.Maps;
import com.jero.common.util.oConvertUtils;
import com.jero.modules.monitor.domain.RedisInfo;
import com.jero.modules.monitor.exception.RedisConnectException;
import com.jero.modules.monitor.service.RedisService;
import lombok.extern.slf4j.Slf4j;
import org.springframework.cglib.beans.BeanMap;
import org.springframework.data.redis.connection.RedisConnectionFactory;
import org.springframework.stereotype.Service;
import lombok.extern.slf4j.Slf4j;
import javax.annotation.Resource;
import java.util.*;
/**
* Redis 监控信息获取
@@ -42,8 +35,9 @@ public class RedisServiceImpl implements RedisService {
@Override
public List<RedisInfo> getRedisInfo() throws RedisConnectException {
Properties info = redisConnectionFactory.getConnection().info();
if(info==null)
if(info==null) {
return new ArrayList<>();
}
List<RedisInfo> infoList = new ArrayList<>();
RedisInfo redisInfo = null;
for (Map.Entry<Object, Object> entry : info.entrySet()) {
@@ -70,8 +64,9 @@ public class RedisServiceImpl implements RedisService {
public Map<String, Object> getMemoryInfo() throws RedisConnectException {
Map<String, Object> map = null;
Properties info = redisConnectionFactory.getConnection().info();
if(info==null)
if(info==null) {
return new HashMap<>();
}
for (Map.Entry<Object, Object> entry : info.entrySet()) {
String key = oConvertUtils.getString(entry.getKey());
if (USER_MEMORY.equals(key)) {
@@ -97,12 +92,8 @@ public class RedisServiceImpl implements RedisService {
if("3".equals(type)){
List<RedisInfo> redisInfo = getRedisInfo();
for(RedisInfo info:redisInfo){
Map<String, Object> map= Maps.newHashMap();
BeanMap beanMap = BeanMap.create(info);
for (Object key : beanMap.keySet()) {
map.put(key+"", beanMap.get(key));
}
json.add(map);
json.add(beanMap);
}
mapJson.put("data",json);
return mapJson;