【fix sonar】OnlCgformButtonController文件

This commit is contained in:
梁琦涛
2023-03-13 14:51:10 +08:00
parent c5c4aa36cb
commit 1de55e62e6
@@ -1,6 +1,7 @@
package com.jero.generater.modules.online.cgform.controller;
import com.alibaba.fastjson.JSON;
import com.alibaba.fastjson.JSONArray;
import com.alibaba.fastjson.JSONObject;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
@@ -32,15 +33,16 @@ public class OnlCgformButtonController {
@Autowired
private IOnlCgformButtonService onlCgformButtonService;
public OnlCgformButtonController() {
}
private static final String OP_SUCCESS = "操作成功!";
private static final String EN_IS_NULL = "未找到对应实体";
@GetMapping({"/list/{code}"})
public Result<IPage<OnlCgformButton>> list(OnlCgformButton var1, @RequestParam(name = "pageNo",defaultValue = "1") Integer var2, @RequestParam(name = "pageSize",defaultValue = "10") Integer var3, HttpServletRequest var4, @PathVariable("code") String var5) {
Result var6 = new Result();
var1.setCgformHeadId(var5);
QueryWrapper var7 = QueryGenerator.initQueryWrapper(var1, var4.getParameterMap());
Page var8 = new Page((long)var2, (long)var3);
Page var8 = new Page(var2, var3);
IPage var9 = this.onlCgformButtonService.page(var8, var7);
var6.setSuccess(true);
var6.setResult(var9);
@@ -51,7 +53,7 @@ public class OnlCgformButtonController {
public Result<Object> add(@RequestBody OnlCgformButton cgformButton) {
try {
this.onlCgformButtonService.save(cgformButton);
return Result.OK("操作成功!");
return Result.OK(OP_SUCCESS);
} catch (Exception e) {
log.error(e.getMessage(), e);
return Result.error("操作失败");
@@ -63,10 +65,10 @@ public class OnlCgformButtonController {
try {
for(int i = 0; i < jsonArray.size(); ++i) {
JSONObject jsonObject = jsonArray.getJSONObject(i);
OnlCgformButton cgformButton = (OnlCgformButton)JSONObject.parseObject(jsonObject.toJSONString(), OnlCgformButton.class);
OnlCgformButton cgformButton = JSON.parseObject(jsonObject.toJSONString(), OnlCgformButton.class);
this.onlCgformButtonService.saveButton(cgformButton);
}
return Result.OK("操作成功!");
return Result.OK(OP_SUCCESS);
} catch (Exception e) {
log.error(e.getMessage(), e);
return Result.error("操作失败");
@@ -75,13 +77,13 @@ public class OnlCgformButtonController {
@PutMapping({"/edit"})
public Result<Object> edit(@RequestBody OnlCgformButton cgformButton) {
OnlCgformButton existCgformButton = (OnlCgformButton)this.onlCgformButtonService.getById(cgformButton.getId());
OnlCgformButton existCgformButton = this.onlCgformButtonService.getById(cgformButton.getId());
if (existCgformButton == null) {
return Result.error("未找到对应实体");
return Result.error(EN_IS_NULL);
} else {
boolean flag = this.onlCgformButtonService.updateById(cgformButton);
if (flag) {
return Result.OK("操作成功!");
return Result.OK(OP_SUCCESS);
}
}
@@ -90,9 +92,9 @@ public class OnlCgformButtonController {
@DeleteMapping({"/delete"})
public Result<Object> delete(@RequestParam(name = "id",required = true) String id) {
OnlCgformButton cgformButton = (OnlCgformButton)this.onlCgformButtonService.getById(id);
OnlCgformButton cgformButton = this.onlCgformButtonService.getById(id);
if (cgformButton == null) {
return Result.error("未找到对应实体");
return Result.error(EN_IS_NULL);
} else {
boolean flag = this.onlCgformButtonService.removeById(id);
if (flag) {
@@ -115,9 +117,9 @@ public class OnlCgformButtonController {
@GetMapping({"/queryById"})
public Result<OnlCgformButton> queryById(@RequestParam(name = "id",required = true) String id) {
OnlCgformButton cgformButton = (OnlCgformButton)this.onlCgformButtonService.getById(id);
OnlCgformButton cgformButton = this.onlCgformButtonService.getById(id);
if (cgformButton == null) {
return Result.error("未找到对应实体");
return Result.error(EN_IS_NULL);
} else {
return Result.OK(cgformButton);
}