【fix sonar】 JobLosedMonitorHelper.java文件

This commit is contained in:
tianwenbo
2023-03-10 16:25:12 +08:00
parent 703c42c936
commit bd2351389f
@@ -19,7 +19,7 @@ import java.util.concurrent.TimeUnit;
*/ */
public class JobLosedMonitorHelper { public class JobLosedMonitorHelper {
private static Logger logger = LoggerFactory.getLogger(JobLosedMonitorHelper.class); private static Logger logger = LoggerFactory.getLogger(JobLosedMonitorHelper.class);
private static JobLosedMonitorHelper instance = new JobLosedMonitorHelper(); private static JobLosedMonitorHelper instance = new JobLosedMonitorHelper();
public static JobLosedMonitorHelper getInstance(){ public static JobLosedMonitorHelper getInstance(){
return instance; return instance;
@@ -30,11 +30,7 @@ public class JobLosedMonitorHelper {
private Thread monitorThread; private Thread monitorThread;
private volatile boolean toStop = false; private volatile boolean toStop = false;
public void start(){ public void start(){
monitorThread = new Thread(new Runnable() { monitorThread = new Thread(()->{
@Override
public void run() {
// monitor // monitor
while (!toStop) { while (!toStop) {
try { try {
@@ -42,7 +38,7 @@ public class JobLosedMonitorHelper {
Date losedTime = DateUtil.addMinutes(new Date(), -10); Date losedTime = DateUtil.addMinutes(new Date(), -10);
List<Long> losedJobIds = XxlJobAdminConfig.getAdminConfig().getXxlJobLogDao().findLostJobIds(losedTime); List<Long> losedJobIds = XxlJobAdminConfig.getAdminConfig().getXxlJobLogDao().findLostJobIds(losedTime);
if (losedJobIds!=null && losedJobIds.size()>0) { if (losedJobIds!=null && !losedJobIds.isEmpty()) {
for (Long logId: losedJobIds) { for (Long logId: losedJobIds) {
XxlJobLog jobLog = new XxlJobLog(); XxlJobLog jobLog = new XxlJobLog();
@@ -61,7 +57,6 @@ public class JobLosedMonitorHelper {
logger.error(">>>>>>>>>>> xxl-job, job fail monitor thread error:{}", e); logger.error(">>>>>>>>>>> xxl-job, job fail monitor thread error:{}", e);
} }
} }
try { try {
TimeUnit.SECONDS.sleep(60); TimeUnit.SECONDS.sleep(60);
} catch (Exception e) { } catch (Exception e) {
@@ -69,12 +64,8 @@ public class JobLosedMonitorHelper {
logger.error(e.getMessage(), e); logger.error(e.getMessage(), e);
} }
} }
} }
logger.info(">>>>>>>>>>> xxl-job, JobLosedMonitorHelper stop"); logger.info(">>>>>>>>>>> xxl-job, JobLosedMonitorHelper stop");
}
}); });
monitorThread.setDaemon(true); monitorThread.setDaemon(true);
monitorThread.setName("xxl-job, admin JobLosedMonitorHelper"); monitorThread.setName("xxl-job, admin JobLosedMonitorHelper");