From bd2351389f5896279d8b58b29cd3b5d6213ce063 Mon Sep 17 00:00:00 2001
From: tianwenbo <tianwenbo@syxysoft.com>
Date: Fri, 10 Mar 2023 16:25:12 +0800
Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91=20JobLosedMonitor?=
 =?UTF-8?q?Helper.java=E6=96=87=E4=BB=B6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../admin/core/thread/JobLosedMonitorHelper.java  | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLosedMonitorHelper.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLosedMonitorHelper.java
index 488443f9..b5575253 100644
--- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLosedMonitorHelper.java
+++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLosedMonitorHelper.java
@@ -19,7 +19,7 @@ import java.util.concurrent.TimeUnit;
  */
 public class JobLosedMonitorHelper {
 	private static Logger logger = LoggerFactory.getLogger(JobLosedMonitorHelper.class);
-	
+
 	private static JobLosedMonitorHelper instance = new JobLosedMonitorHelper();
 	public static JobLosedMonitorHelper getInstance(){
 		return instance;
@@ -30,11 +30,7 @@ public class JobLosedMonitorHelper {
 	private Thread monitorThread;
 	private volatile boolean toStop = false;
 	public void start(){
-		monitorThread = new Thread(new Runnable() {
-
-			@Override
-			public void run() {
-
+		monitorThread = new Thread(()->{
 				// monitor
 				while (!toStop) {
 					try {
@@ -42,7 +38,7 @@ public class JobLosedMonitorHelper {
 						Date losedTime = DateUtil.addMinutes(new Date(), -10);
 						List<Long> losedJobIds  = XxlJobAdminConfig.getAdminConfig().getXxlJobLogDao().findLostJobIds(losedTime);
 
-						if (losedJobIds!=null && losedJobIds.size()>0) {
+						if (losedJobIds!=null && !losedJobIds.isEmpty()) {
 							for (Long logId: losedJobIds) {
 
 								XxlJobLog jobLog = new XxlJobLog();
@@ -61,7 +57,6 @@ public class JobLosedMonitorHelper {
 							logger.error(">>>>>>>>>>> xxl-job, job fail monitor thread error:{}", e);
 						}
 					}
-
                     try {
                         TimeUnit.SECONDS.sleep(60);
                     } catch (Exception e) {
@@ -69,12 +64,8 @@ public class JobLosedMonitorHelper {
                             logger.error(e.getMessage(), e);
                         }
                     }
-
                 }
-
 				logger.info(">>>>>>>>>>> xxl-job, JobLosedMonitorHelper stop");
-
-			}
 		});
 		monitorThread.setDaemon(true);
 		monitorThread.setName("xxl-job, admin JobLosedMonitorHelper");