代码审查

jero-boot/jero-boot-modules/src/main/java/com/jero/modules/tag/controller/OnlCgformTagController.java

@@ -38,6 +38,7 @@ import java.util.List;
 public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgformTagService> {
 	@Autowired
 	private IOnlCgformTagService onlCgformTagService;
+	//TODO 定以为私有变量
 	@Autowired
 	OnlCgformTagController onlCgformAreaService;
 	/**
@@ -124,6 +125,7 @@ public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgf
 		Result<OnlCgformTag> result = new Result<>();
 		OnlCgformTag onlCgformTag = onlCgformTagService.queryById(id);
 		if(StringUtils.isNotBlank(String.valueOf(onlCgformTag.getIsReadOnly()))) {
+			//TODO 使用枚举的形式定义
 			if (onlCgformTag.getIsReadOnly() == 1 || onlCgformTag.getIsReadOnly() == 2) {
 				result.error500("固定字段,不可删除");
 			} else {
@@ -145,6 +147,7 @@ public class OnlCgformTagController extends JeroController<OnlCgformTag, IOnlCgf
 	@DeleteMapping(value = "/deleteBatch")
 	public Result<?> deleteBatch(@RequestParam(name="ids",required=true) String ids) {
 		OnlCgformTag onlCgformTag = onlCgformTagService.queryById(ids);
+		//TODO 使用枚举的形式定义
 		if(onlCgformTag.getIsReadOnly() == 1 || onlCgformTag.getIsReadOnly()==2){
 			return Result.error("固定字段,不可删除");
 		}else {

jero-boot/jero-boot-modules/src/main/java/com/jero/modules/tag/entity/OnlCgformArea.java

@@ -80,6 +80,7 @@ public class OnlCgformArea implements Serializable {
     @ApiModelProperty(value = "排序号")
     private java.lang.Integer sort;
 
+    //TODO 定义@data后不需要再重写get/set方法
     public void setShowArea(String showArea) {
         this.showArea = showArea;
     }