From 6d135d0a6bfa0bc6a9fa92d74eac32303c8355e5 Mon Sep 17 00:00:00 2001
From: danshihao <danshihao@syxysoft.com>
Date: Fri, 3 Mar 2023 16:11:16 +0800
Subject: [PATCH 1/3] =?UTF-8?q?=E3=80=90fix=20ESLint=E3=80=91src/component?=
 =?UTF-8?q?s/setting/SettingDrawer.js?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 jero-web/src/components/setting/SettingDrawer.vue | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/jero-web/src/components/setting/SettingDrawer.vue b/jero-web/src/components/setting/SettingDrawer.vue
index fe0c6ecf..2bdf5d45 100644
--- a/jero-web/src/components/setting/SettingDrawer.vue
+++ b/jero-web/src/components/setting/SettingDrawer.vue
@@ -163,8 +163,8 @@
 </template>
 
 <script>
-import DetailList from '@/components/tools/DetailList'
-import SettingItem from '@/components/setting/SettingItem'
+// import DetailList from '@/components/tools/DetailList'
+// import SettingItem from '@/components/setting/SettingItem'
 import config from '@/defaultSettings'
 import { updateTheme, updateColorWeak, colorList } from '@/components/tools/setting'
 import { mixin, mixinDevice } from '@/utils/mixin.js'
@@ -172,8 +172,8 @@ import { triggerWindowResizeEvent } from '@/utils/util'
 
 export default {
   components: {
-    DetailList,
-    SettingItem
+    // DetailList,
+    // SettingItem
   },
   mixins: [mixin, mixinDevice],
   data () {
@@ -286,8 +286,8 @@ export default {
       float: left;
       cursor: pointer;
       margin-right: 8px;
-      padding-left: 0px;
-      padding-right: 0px;
+      padding-left: 0;
+      padding-right: 0;
       text-align: center;
       color: #fff;
       font-weight: 700;

From 03c7670e0b0e715ab6557d985e48e482bb7ccaf4 Mon Sep 17 00:00:00 2001
From: tianwenbo <tianwenbo@syxysoft.com>
Date: Fri, 3 Mar 2023 15:58:55 +0800
Subject: [PATCH 2/3] =?UTF-8?q?Revert=20"=E3=80=90fix=20sonar=E3=80=91NgAl?=
 =?UTF-8?q?ainServiceImpl.java.java=E6=96=87=E4=BB=B6"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit ebbda7d1709adae925282dc4ec0a315caf698d9a.
---
 .../service/impl/NgAlainServiceImpl.java      | 112 ++++++++----------
 1 file changed, 50 insertions(+), 62 deletions(-)

diff --git a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
index 0ae52c52..9999c614 100644
--- a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
+++ b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
@@ -21,8 +21,6 @@ public class NgAlainServiceImpl implements NgAlainService {
     private ISysPermissionService sysPermissionService;
     @Autowired
     private SysDictMapper mapper;
-
-    private static String CHILDREN = "children";
     @Override
     public JSONArray getMenu(String id) throws Exception {
         return getJeroMenu(id);
@@ -36,7 +34,7 @@ public class NgAlainServiceImpl implements NgAlainService {
         JSONObject menu = new JSONObject();
         menu.put("text", "jero菜单");
         menu.put("group",true);
-        menu.put(CHILDREN, menulist);
+        menu.put("children", menulist);
         JSONArray jeroMenuList=new JSONArray();
         jeroMenuList.add(menu);
         return jeroMenuList;
@@ -56,9 +54,9 @@ public class NgAlainServiceImpl implements NgAlainService {
             JSONObject menu=new JSONObject();
             menu.put("text",meta.get("title"));
             menu.put("reuse",true);
-            if (jsonObject.get(CHILDREN)!=null){
-                JSONArray child=  parseNgAlain((JSONArray) jsonObject.get(CHILDREN));
-                menu.put(CHILDREN,child);
+            if (jsonObject.get("children")!=null){
+                JSONArray child=  parseNgAlain((JSONArray) jsonObject.get("children"));
+                menu.put("children",child);
                 JSONObject icon=new JSONObject();
                 icon.put("type", "icon");
                 icon.put("value", meta.get("icon"));
@@ -78,7 +76,6 @@ public class NgAlainServiceImpl implements NgAlainService {
      * @param parentJson
      */
     private void getPermissionJsonArray(JSONArray jsonArray,List<SysPermission> metaList,JSONObject parentJson) {
-        String PERMISSIONLIST = "permissionList";
         for (SysPermission permission : metaList) {
             if(permission.getMenuType()==null) {
                 continue;
@@ -91,38 +88,34 @@ public class NgAlainServiceImpl implements NgAlainService {
                     getPermissionJsonArray(jsonArray, metaList, json);
                 }
             }else if(parentJson!=null && oConvertUtils.isNotEmpty(tempPid) && tempPid.equals(parentJson.getString("id"))){
-                permissionType(jsonArray, metaList, parentJson, PERMISSIONLIST, permission, json);
+                if(permission.getMenuType()==0) {
+                    JSONObject metaJson = parentJson.getJSONObject("meta");
+                    if(metaJson.containsKey("permissionList")) {
+                        metaJson.getJSONArray("permissionList").add(json);
+                    }else {
+                        JSONArray permissionList = new JSONArray();
+                        permissionList.add(json);
+                        metaJson.put("permissionList", permissionList);
+                    }
+
+                }else if(permission.getMenuType()==1) {
+                    if(parentJson.containsKey("children")) {
+                        parentJson.getJSONArray("children").add(json);
+                    }else {
+                        JSONArray children = new JSONArray();
+                        children.add(json);
+                        parentJson.put("children", children);
+                    }
+
+                    if(!permission.isLeaf()) {
+                        getPermissionJsonArray(jsonArray, metaList, json);
+                    }
+                }
             }
 
+
         }
     }
-
-    private void permissionType(JSONArray jsonArray, List<SysPermission> metaList, JSONObject parentJson, String PERMISSIONLIST, SysPermission permission, JSONObject json) {
-        if(permission.getMenuType()==0) {
-            JSONObject metaJson = parentJson.getJSONObject("meta");
-            if(metaJson.containsKey(PERMISSIONLIST)) {
-                metaJson.getJSONArray(PERMISSIONLIST).add(json);
-            }else {
-                JSONArray permissionList = new JSONArray();
-                permissionList.add(json);
-                metaJson.put(PERMISSIONLIST, permissionList);
-            }
-
-        }else if(permission.getMenuType()==1) {
-            if(parentJson.containsKey(CHILDREN)) {
-                parentJson.getJSONArray(CHILDREN).add(json);
-            }else {
-                JSONArray children = new JSONArray();
-                children.add(json);
-                parentJson.put(CHILDREN, children);
-            }
-
-            if(!permission.isLeaf()) {
-                getPermissionJsonArray(jsonArray, metaList, json);
-            }
-        }
-    }
-
     private JSONObject getPermissionJsonObject(SysPermission permission) {
         JSONObject json = new JSONObject();
         //类型(0：一级菜单 1：子菜单  2：按钮)
@@ -133,7 +126,7 @@ public class NgAlainServiceImpl implements NgAlainService {
             json.put("id", permission.getId());
             if(permission.getUrl()!=null&&(permission.getUrl().startsWith("http://")||permission.getUrl().startsWith("https://"))) {
                 String url= new String(Base64.getUrlEncoder().encode(permission.getUrl().getBytes()));
-                json.put("path", "/sys/link/" +url.replace("=",""));
+                json.put("path", "/sys/link/" +url.replaceAll("=",""));
             }else {
                 json.put("path", permission.getUrl());
             }
@@ -142,36 +135,31 @@ public class NgAlainServiceImpl implements NgAlainService {
             json.put("name", urlToRouteName(permission.getUrl()));
 
             //是否隐藏路由，默认都是显示的
-            setRouter(permission, json);
+            if(permission.isHidden()) {
+                json.put("hidden",true);
+            }
+            //聚合路由
+            if(permission.isAlwaysShow()) {
+                json.put("alwaysShow",true);
+            }
+            json.put("component", permission.getComponent());
+            JSONObject meta = new JSONObject();
+            meta.put("title", permission.getName());
+            if(oConvertUtils.isEmpty(permission.getParentId())) {
+                //一级菜单跳转地址
+                json.put("redirect",permission.getRedirect());
+                meta.put("icon", oConvertUtils.getString(permission.getIcon(), ""));
+            }else {
+                meta.put("icon", oConvertUtils.getString(permission.getIcon(), ""));
+            }
+            if(permission.getUrl()!=null&&(permission.getUrl().startsWith("http://")||permission.getUrl().startsWith("https://"))) {
+                meta.put("url", permission.getUrl());
+            }
+            json.put("meta", meta);
         }
 
         return json;
     }
-
-    private void setRouter(SysPermission permission, JSONObject json) {
-        if(permission.isHidden()) {
-            json.put("hidden",true);
-        }
-        //聚合路由
-        if(permission.isAlwaysShow()) {
-            json.put("alwaysShow",true);
-        }
-        json.put("component", permission.getComponent());
-        JSONObject meta = new JSONObject();
-        meta.put("title", permission.getName());
-        if(oConvertUtils.isEmpty(permission.getParentId())) {
-            //一级菜单跳转地址
-            json.put("redirect", permission.getRedirect());
-            meta.put("icon", oConvertUtils.getString(permission.getIcon(), ""));
-        }else {
-            meta.put("icon", oConvertUtils.getString(permission.getIcon(), ""));
-        }
-        if(permission.getUrl()!=null&&(permission.getUrl().startsWith("http://")|| permission.getUrl().startsWith("https://"))) {
-            meta.put("url", permission.getUrl());
-        }
-        json.put("meta", meta);
-    }
-
     /**
      * 通过URL生成路由name（去掉URL前缀斜杠，替换内容中的斜杠‘/’为-）
      * 举例： URL = /isystem/role

From 14fd215576fd3a103e19118e31145fe3405778dd Mon Sep 17 00:00:00 2001
From: tianwenbo <tianwenbo@syxysoft.com>
Date: Fri, 3 Mar 2023 16:24:45 +0800
Subject: [PATCH 3/3] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91NgAlainService?=
 =?UTF-8?q?Impl.java=20=E6=96=87=E4=BB=B6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../service/impl/NgAlainServiceImpl.java      | 24 ++++++++++---------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
index 9999c614..b2e3e076 100644
--- a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
+++ b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/ngalain/service/impl/NgAlainServiceImpl.java
@@ -21,6 +21,7 @@ public class NgAlainServiceImpl implements NgAlainService {
     private ISysPermissionService sysPermissionService;
     @Autowired
     private SysDictMapper mapper;
+    private static String CHILDREN ="children";
     @Override
     public JSONArray getMenu(String id) throws Exception {
         return getJeroMenu(id);
@@ -34,7 +35,7 @@ public class NgAlainServiceImpl implements NgAlainService {
         JSONObject menu = new JSONObject();
         menu.put("text", "jero菜单");
         menu.put("group",true);
-        menu.put("children", menulist);
+        menu.put(CHILDREN, menulist);
         JSONArray jeroMenuList=new JSONArray();
         jeroMenuList.add(menu);
         return jeroMenuList;
@@ -54,9 +55,9 @@ public class NgAlainServiceImpl implements NgAlainService {
             JSONObject menu=new JSONObject();
             menu.put("text",meta.get("title"));
             menu.put("reuse",true);
-            if (jsonObject.get("children")!=null){
-                JSONArray child=  parseNgAlain((JSONArray) jsonObject.get("children"));
-                menu.put("children",child);
+            if (jsonObject.get(CHILDREN)!=null){
+                JSONArray child=  parseNgAlain((JSONArray) jsonObject.get(CHILDREN));
+                menu.put(CHILDREN,child);
                 JSONObject icon=new JSONObject();
                 icon.put("type", "icon");
                 icon.put("value", meta.get("icon"));
@@ -88,23 +89,24 @@ public class NgAlainServiceImpl implements NgAlainService {
                     getPermissionJsonArray(jsonArray, metaList, json);
                 }
             }else if(parentJson!=null && oConvertUtils.isNotEmpty(tempPid) && tempPid.equals(parentJson.getString("id"))){
+                String PERMISSIONLIST = "permissionList";
                 if(permission.getMenuType()==0) {
                     JSONObject metaJson = parentJson.getJSONObject("meta");
-                    if(metaJson.containsKey("permissionList")) {
-                        metaJson.getJSONArray("permissionList").add(json);
+                    if(metaJson.containsKey(PERMISSIONLIST)) {
+                        metaJson.getJSONArray(PERMISSIONLIST).add(json);
                     }else {
                         JSONArray permissionList = new JSONArray();
                         permissionList.add(json);
-                        metaJson.put("permissionList", permissionList);
+                        metaJson.put(PERMISSIONLIST, permissionList);
                     }
 
                 }else if(permission.getMenuType()==1) {
-                    if(parentJson.containsKey("children")) {
-                        parentJson.getJSONArray("children").add(json);
+                    if(parentJson.containsKey(CHILDREN)) {
+                        parentJson.getJSONArray(CHILDREN).add(json);
                     }else {
                         JSONArray children = new JSONArray();
                         children.add(json);
-                        parentJson.put("children", children);
+                        parentJson.put(CHILDREN, children);
                     }
 
                     if(!permission.isLeaf()) {
@@ -126,7 +128,7 @@ public class NgAlainServiceImpl implements NgAlainService {
             json.put("id", permission.getId());
             if(permission.getUrl()!=null&&(permission.getUrl().startsWith("http://")||permission.getUrl().startsWith("https://"))) {
                 String url= new String(Base64.getUrlEncoder().encode(permission.getUrl().getBytes()));
-                json.put("path", "/sys/link/" +url.replaceAll("=",""));
+                json.put("path", "/sys/link/" +url.replace("=",""));
             }else {
                 json.put("path", permission.getUrl());
             }