From a7e855dd6af66d8e65d3893a4ca806be22712410 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=A2=81=E7=90=A6=E6=B6=9B?= Date: Mon, 13 Mar 2023 14:51:29 +0800 Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91OnlCgformFieldCont?= =?UTF-8?q?roller=E6=96=87=E4=BB=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../controller/OnlCgformFieldController.java | 35 +++++++++---------- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/jero-boot/jero-boot-base/jero-boot-base-generater/src/main/java/com/jero/generater/modules/online/cgform/controller/OnlCgformFieldController.java b/jero-boot/jero-boot-base/jero-boot-base-generater/src/main/java/com/jero/generater/modules/online/cgform/controller/OnlCgformFieldController.java index 84c1208d..e5f7bcd6 100644 --- a/jero-boot/jero-boot-base/jero-boot-base-generater/src/main/java/com/jero/generater/modules/online/cgform/controller/OnlCgformFieldController.java +++ b/jero-boot/jero-boot-base/jero-boot-base-generater/src/main/java/com/jero/generater/modules/online/cgform/controller/OnlCgformFieldController.java @@ -34,32 +34,31 @@ public class OnlCgformFieldController { @Autowired private IOnlCgformFieldService onlCgformFieldService; - public OnlCgformFieldController() { - } + private static final String EN_IS_NULL = "未找到对应实体"; @GetMapping({"/listByHeadCode"}) - public Result a(@RequestParam("headCode") String var1) { - LambdaQueryWrapper var2 = new LambdaQueryWrapper(); + public Result a(@RequestParam("headCode") String var1) { + LambdaQueryWrapper var2 = new LambdaQueryWrapper<>(); var2.eq(OnlCgformHead::getTableName, var1); - OnlCgformHead var3 = (OnlCgformHead)this.onlCgformHeadService.getOne(var2); + OnlCgformHead var3 = this.onlCgformHeadService.getOne(var2); return var3 == null ? Result.error("不存在的code") : this.b(var3.getId()); } @GetMapping({"/listByHeadId"}) - public Result b(@RequestParam("headId") String var1) { - QueryWrapper var2 = new QueryWrapper(); + public Result b(@RequestParam("headId") String var1) { + QueryWrapper var2 = new QueryWrapper<>(); var2.eq("cgform_head_id", var1); var2.orderByAsc("order_num"); - List var3 = this.onlCgformFieldService.list(var2); + List var3 = this.onlCgformFieldService.list(var2); return Result.OK(var3); } @GetMapping({"/list"}) public Result> a(OnlCgformField var1, @RequestParam(name = "pageNo",defaultValue = "1") Integer var2, @RequestParam(name = "pageSize",defaultValue = "10") Integer var3, HttpServletRequest var4) { - Result var5 = new Result(); - QueryWrapper var6 = QueryGenerator.initQueryWrapper(var1, var4.getParameterMap()); - Page var7 = new Page((long)var2, (long)var3); - IPage var8 = this.onlCgformFieldService.page(var7, var6); + Result var5 = new Result<>(); + QueryWrapper var6 = QueryGenerator.initQueryWrapper(var1, var4.getParameterMap()); + Page var7 = new Page<>(var2, var3); + IPage var8 = this.onlCgformFieldService.page(var7, var6); var5.setSuccess(true); var5.setResult(var8); return var5; @@ -78,9 +77,9 @@ public class OnlCgformFieldController { @PutMapping({"/edit"}) public Result edit(@RequestBody OnlCgformField var1) { - OnlCgformField var3 = (OnlCgformField)this.onlCgformFieldService.getById(var1.getId()); + OnlCgformField var3 = this.onlCgformFieldService.getById(var1.getId()); if (var3 == null) { - return Result.error("未找到对应实体"); + return Result.error(EN_IS_NULL); } else { boolean var4 = this.onlCgformFieldService.updateById(var1); if (var4) { @@ -92,9 +91,9 @@ public class OnlCgformFieldController { @DeleteMapping({"/delete"}) public Result delete(@RequestParam(name = "id",required = true) String var1) { - OnlCgformField var3 = (OnlCgformField)this.onlCgformFieldService.getById(var1); + OnlCgformField var3 = this.onlCgformFieldService.getById(var1); if (var3 == null) { - return Result.error("未找到对应实体"); + return Result.error(EN_IS_NULL); } else { boolean var4 = this.onlCgformFieldService.removeById(var1); if (var4) { @@ -117,9 +116,9 @@ public class OnlCgformFieldController { @GetMapping({"/queryById"}) public Result queryById(@RequestParam(name = "id",required = true) String var1) { - OnlCgformField var3 = (OnlCgformField)this.onlCgformFieldService.getById(var1); + OnlCgformField var3 = this.onlCgformFieldService.getById(var1); if (var3 == null) { - return Result.error("未找到对应实体"); + return Result.error(EN_IS_NULL); } else { return Result.OK(var3); }