【fix sonar】JeroDemoServiceImpl文件

jero-boot/jero-boot-module-demo/src/main/java/com/jero/modules/demo/test/service/impl/JeroDemoServiceImpl.java

@@ -3,7 +3,9 @@ package com.jero.modules.demo.test.service.impl;
 import com.baomidou.mybatisplus.core.metadata.IPage;
 import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
 import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
+import com.jero.common.exception.JeroBootException;
 import com.jero.modules.demo.test.entity.JeroDemo;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.shiro.SecurityUtils;
 import com.jero.common.constant.CacheConstant;
 import com.jero.common.system.query.QueryGenerator;
@@ -26,35 +28,35 @@ import java.util.List;
  * @Date:  2018-12-29
  * @Version: V1.0
  */
+@Slf4j
 @Service
 public class JeroDemoServiceImpl extends ServiceImpl<JeroDemoMapper, JeroDemo> implements IJeroDemoService {
 	@Autowired
-	JeroDemoMapper JeroDemoMapper;
+	JeroDemoMapper jeroDemoMapper;
-	
+
 	/**
 	 * 事务控制在service层面
 	 * 加上注解：@Transactional，声明的方法就是一个独立的事务（有异常DB操作全部回滚）
 	 */
 	@Override
-	@Transactional
+	@Transactional(rollbackFor = JeroBootException.class)
 	public void testTran() {
 		JeroDemo pp = new JeroDemo();
 		pp.setAge(1111);
 		pp.setName("测试事务  小白兔 1");
-		JeroDemoMapper.insert(pp);
+		jeroDemoMapper.insert(pp);
-		
+
 		JeroDemo pp2 = new JeroDemo();
 		pp2.setAge(2222);
 		pp2.setName("测试事务  小白兔 2");
-		JeroDemoMapper.insert(pp2);
+		jeroDemoMapper.insert(pp2);
-		
+
-		Integer.parseInt("hello");//自定义异常
+//		Integer.parseInt("hello");//自定义异常
-		
+
 		JeroDemo pp3 = new JeroDemo();
 		pp3.setAge(3333);
 		pp3.setName("测试事务  小白兔 3");
-		JeroDemoMapper.insert(pp3);
+		jeroDemoMapper.insert(pp3);
-		return ;
 	}
 
 
@@ -64,9 +66,9 @@ public class JeroDemoServiceImpl extends ServiceImpl<JeroDemoMapper, JeroDemo> i
 	@Override
 	@Cacheable(cacheNames = CacheConstant.TEST_DEMO_CACHE, key = "#id")
 	public JeroDemo getByIdCacheable(String id) {
-		JeroDemo t = JeroDemoMapper.selectById(id);
+		JeroDemo t = jeroDemoMapper.selectById(id);
-		System.err.println("---未读缓存，读取数据库---");
+		log.info("---未读缓存，读取数据库---");
-		System.err.println(t);
+		log.error(String.valueOf(t));
 		return t;
 	}
 
@@ -88,9 +90,9 @@ public class JeroDemoServiceImpl extends ServiceImpl<JeroDemoMapper, JeroDemo> i
 		List<String> exportFieldsList = new ArrayList<>();
 		String permsPrefix = "testdemo:";
 		//查询配置菜单有效字段
-		List<String> allAuth = this.JeroDemoMapper.queryAllAuth(permsPrefix);
+		List<String> allAuth = this.jeroDemoMapper.queryAllAuth(permsPrefix);
 		//查询已授权字段
-		List<String> userAuth = this.JeroDemoMapper.queryUserAuth(sysUser.getId(),permsPrefix);
+		List<String> userAuth = this.jeroDemoMapper.queryUserAuth(sysUser.getId(),permsPrefix);
 		//列出未授权字段
 		for(String perms : allAuth){
 			if(!userAuth.contains(perms)){
@@ -99,13 +101,13 @@ public class JeroDemoServiceImpl extends ServiceImpl<JeroDemoMapper, JeroDemo> i
 		}
 		//实体类中字段与未授权字段比较，列出需导出字段
 		Field[] fileds = JeroDemo.class.getDeclaredFields();
-		List<Field> list = new ArrayList(Arrays.asList(fileds));
+		List<Field> list = new ArrayList<>(Arrays.asList(fileds));
 		for(Field field : list){
 			if(!noAuthList.contains(field.getName())){
 				exportFieldsList.add(field.getName());
 			}
 		}
-		return exportFieldsList != null && exportFieldsList.size()>0 ? String.join(",", exportFieldsList) : "";
+		return !exportFieldsList.isEmpty() ? String.join(",", exportFieldsList) : "";
 	}
 
 }