【fix sonar】JoaDemoController文件

This commit is contained in:
梁琦涛
2023-03-09 09:34:06 +08:00
parent 83d96a1c4f
commit 51852da425
@@ -11,6 +11,8 @@ import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import com.jero.common.api.vo.Result; import com.jero.common.api.vo.Result;
import com.jero.common.api.vo.ResultConstant;
import com.jero.common.system.base.controller.JeroController;
import com.jero.common.system.query.QueryGenerator; import com.jero.common.system.query.QueryGenerator;
import com.jero.common.util.oConvertUtils; import com.jero.common.util.oConvertUtils;
import com.jero.modules.demo.test.entity.JoaDemo; import com.jero.modules.demo.test.entity.JoaDemo;
@@ -53,7 +55,7 @@ import lombok.extern.slf4j.Slf4j;
public class JoaDemoController { public class JoaDemoController {
@Autowired @Autowired
private IJoaDemoService joaDemoService; private IJoaDemoService joaDemoService;
/** /**
* 分页列表查询 * 分页列表查询
* @param joaDemo * @param joaDemo
@@ -67,15 +69,15 @@ public class JoaDemoController {
@RequestParam(name="pageNo", defaultValue="1") Integer pageNo, @RequestParam(name="pageNo", defaultValue="1") Integer pageNo,
@RequestParam(name="pageSize", defaultValue="10") Integer pageSize, @RequestParam(name="pageSize", defaultValue="10") Integer pageSize,
HttpServletRequest req) { HttpServletRequest req) {
Result<IPage<JoaDemo>> result = new Result<IPage<JoaDemo>>(); Result<IPage<JoaDemo>> result = new Result<>();
QueryWrapper<JoaDemo> queryWrapper = QueryGenerator.initQueryWrapper(joaDemo, req.getParameterMap()); QueryWrapper<JoaDemo> queryWrapper = QueryGenerator.initQueryWrapper(joaDemo, req.getParameterMap());
Page<JoaDemo> page = new Page<JoaDemo>(pageNo, pageSize); Page<JoaDemo> page = new Page<>(pageNo, pageSize);
IPage<JoaDemo> pageList = joaDemoService.page(page, queryWrapper); IPage<JoaDemo> pageList = joaDemoService.page(page, queryWrapper);
result.setSuccess(true); result.setSuccess(true);
result.setResult(pageList); result.setResult(pageList);
return result; return result;
} }
/** /**
* 添加 * 添加
* @param joaDemo * @param joaDemo
@@ -91,7 +93,7 @@ public class JoaDemoController {
return Result.error("操作失败"); return Result.error("操作失败");
} }
} }
/** /**
* 编辑 * 编辑
* @param joaDemo * @param joaDemo
@@ -101,7 +103,7 @@ public class JoaDemoController {
public Result<Object> edit(@RequestBody JoaDemo joaDemo) { public Result<Object> edit(@RequestBody JoaDemo joaDemo) {
JoaDemo joaDemoEntity = joaDemoService.getById(joaDemo.getId()); JoaDemo joaDemoEntity = joaDemoService.getById(joaDemo.getId());
if(joaDemoEntity==null) { if(joaDemoEntity==null) {
return Result.error("未找到对应实体"); return Result.error(ResultConstant.EN_WAS_NOT_FOUND);
}else { }else {
boolean ok = joaDemoService.updateById(joaDemo); boolean ok = joaDemoService.updateById(joaDemo);
if(ok) { if(ok) {
@@ -111,7 +113,7 @@ public class JoaDemoController {
return Result.OK(); return Result.OK();
} }
/** /**
* 通过id删除 * 通过id删除
* @param id * @param id
@@ -121,7 +123,7 @@ public class JoaDemoController {
public Result<Object> delete(@RequestParam(name="id",required=true) String id) { public Result<Object> delete(@RequestParam(name="id",required=true) String id) {
JoaDemo joaDemo = joaDemoService.getById(id); JoaDemo joaDemo = joaDemoService.getById(id);
if(joaDemo==null) { if(joaDemo==null) {
return Result.error("未找到对应实体"); return Result.error(ResultConstant.EN_WAS_NOT_FOUND);
}else { }else {
boolean ok = joaDemoService.removeById(id); boolean ok = joaDemoService.removeById(id);
if(ok) { if(ok) {
@@ -130,7 +132,7 @@ public class JoaDemoController {
} }
return Result.OK(); return Result.OK();
} }
/** /**
* 批量删除 * 批量删除
* @param ids * @param ids
@@ -145,7 +147,7 @@ public class JoaDemoController {
return Result.OK("删除成功!"); return Result.OK("删除成功!");
} }
} }
/** /**
* 通过id查询 * 通过id查询
* @param id * @param id
@@ -155,7 +157,7 @@ public class JoaDemoController {
public Result<JoaDemo> queryById(@RequestParam(name="id",required=true) String id) { public Result<JoaDemo> queryById(@RequestParam(name="id",required=true) String id) {
JoaDemo joaDemo = joaDemoService.getById(id); JoaDemo joaDemo = joaDemoService.getById(id);
if(joaDemo==null) { if(joaDemo==null) {
return Result.error("未找到对应实体"); return Result.error(ResultConstant.EN_WAS_NOT_FOUND);
}else { }else {
return Result.OK(joaDemo); return Result.OK(joaDemo);
} }
@@ -186,9 +188,9 @@ public class JoaDemoController {
ModelAndView mv = new ModelAndView(new JeecgEntityExcelView()); ModelAndView mv = new ModelAndView(new JeecgEntityExcelView());
List<JoaDemo> pageList = joaDemoService.list(queryWrapper); List<JoaDemo> pageList = joaDemoService.list(queryWrapper);
//导出文件名称 //导出文件名称
mv.addObject(NormalExcelConstants.FILE_NAME, "流程测试列表"); mv.addObject(JeroController.FILE_NAME, "流程测试列表");
mv.addObject(NormalExcelConstants.CLASS, JoaDemo.class); mv.addObject(JeroController.CLASS, JoaDemo.class);
mv.addObject(NormalExcelConstants.PARAMS, new ExportParams("流程测试列表数据", "导出人:Jero", "导出信息")); mv.addObject(JeroController.PARAMS, new ExportParams("流程测试列表数据", "导出人:Jero", "导出信息"));
mv.addObject(NormalExcelConstants.DATA_LIST, pageList); mv.addObject(NormalExcelConstants.DATA_LIST, pageList);
return mv; return mv;
} }
@@ -201,7 +203,7 @@ public class JoaDemoController {
* @return * @return
*/ */
@RequestMapping(value = "/importExcel", method = RequestMethod.POST) @RequestMapping(value = "/importExcel", method = RequestMethod.POST)
public Result<?> importExcel(HttpServletRequest request, HttpServletResponse response) { public Result importExcel(HttpServletRequest request, HttpServletResponse response) {
MultipartHttpServletRequest multipartRequest = (MultipartHttpServletRequest) request; MultipartHttpServletRequest multipartRequest = (MultipartHttpServletRequest) request;
Map<String, MultipartFile> fileMap = multipartRequest.getFileMap(); Map<String, MultipartFile> fileMap = multipartRequest.getFileMap();
for (Map.Entry<String, MultipartFile> entity : fileMap.entrySet()) { for (Map.Entry<String, MultipartFile> entity : fileMap.entrySet()) {