KH/kh-device-admin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

【fix sonar】 AdminBizImpl.java文件

Browse Source
This commit is contained in:
tianwenbo
2023-03-10 10:50:21 +08:00
parent 22a3d4a558
commit 38bdb7a14b
1 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/service/impl/AdminBizImpl.java
+17 -17
View File
@@ -29,7 +29,7 @@ import java.util.List;
*/ */
@Service @Service
public class AdminBizImpl implements AdminBiz { public class AdminBizImpl implements AdminBiz {
private static Logger logger = LoggerFactory.getLogger(AdminBizImpl.class); private static final Logger logger = LoggerFactory.getLogger(AdminBizImpl.class);
@Resource @Resource
public XxlJobLogDao xxlJobLogDao; public XxlJobLogDao xxlJobLogDao;
@@ -56,18 +56,18 @@ public class AdminBizImpl implements AdminBiz {
// valid log item // valid log item
XxlJobLog log = xxlJobLogDao.load(handleCallbackParam.getLogId()); XxlJobLog log = xxlJobLogDao.load(handleCallbackParam.getLogId());
if (log == null) { if (log == null) {
return new ReturnT<String>(ReturnT.FAIL_CODE, "log item not found."); return new ReturnT<>(ReturnT.FAIL_CODE, "log item not found.");
} }
if (log.getHandleCode() > 0) { if (log.getHandleCode() > 0) {
return new ReturnT<String>(ReturnT.FAIL_CODE, "log repeate callback."); // avoid repeat callback, trigger child job etc return new ReturnT<>(ReturnT.FAIL_CODE, "log repeate callback."); // avoid repeat callback, trigger child job etc
} }
// trigger success, to trigger child job // trigger success, to trigger child job
String callbackMsg = null; StringBuilder callbackMsg = null;
if (IJobHandler.SUCCESS.getCode() == handleCallbackParam.getExecuteResult().getCode()) { if (IJobHandler.SUCCESS.getCode() == handleCallbackParam.getExecuteResult().getCode()) {
XxlJobInfo xxlJobInfo = xxlJobInfoDao.loadById(log.getJobId()); XxlJobInfo xxlJobInfo = xxlJobInfoDao.loadById(log.getJobId());
if (xxlJobInfo!=null && xxlJobInfo.getChildJobId()!=null && xxlJobInfo.getChildJobId().trim().length()>0) { if (xxlJobInfo!=null && xxlJobInfo.getChildJobId()!=null && xxlJobInfo.getChildJobId().trim().length()>0) {
callbackMsg = "<br><br><span style=\"color:#00c0ef;\" > >>>>>>>>>>>"+ I18nUtil.getString("jobconf_trigger_child_run") +"<<<<<<<<<<< </span><br>"; callbackMsg = new StringBuilder("<br><br><span style=\"color:#00c0ef;\" > >>>>>>>>>>>" + I18nUtil.getString("jobconf_trigger_child_run") + "<<<<<<<<<<< </span><br>");
String[] childJobIds = xxlJobInfo.getChildJobId().split(","); String[] childJobIds = xxlJobInfo.getChildJobId().split(",");
for (int i = 0; i < childJobIds.length; i++) { for (int i = 0; i < childJobIds.length; i++) {
@@ -78,17 +78,17 @@ public class AdminBizImpl implements AdminBiz {
ReturnT<String> triggerChildResult = ReturnT.SUCCESS; ReturnT<String> triggerChildResult = ReturnT.SUCCESS;
// add msg // add msg
callbackMsg += MessageFormat.format(I18nUtil.getString("jobconf_callback_child_msg1"), callbackMsg.append(MessageFormat.format(I18nUtil.getString("jobconf_callback_child_msg1"),
(i+1), (i + 1),
childJobIds.length, childJobIds.length,
childJobIds[i], childJobIds[i],
(triggerChildResult.getCode()==ReturnT.SUCCESS_CODE?I18nUtil.getString("system_success"):I18nUtil.getString("system_fail")), (triggerChildResult.getCode() == ReturnT.SUCCESS_CODE ? I18nUtil.getString("system_success") : I18nUtil.getString("system_fail")),
triggerChildResult.getMsg()); triggerChildResult.getMsg()));
} else { } else {
callbackMsg += MessageFormat.format(I18nUtil.getString("jobconf_callback_child_msg2"), callbackMsg.append(MessageFormat.format(I18nUtil.getString("jobconf_callback_child_msg2"),
(i+1), (i + 1),
childJobIds.length, childJobIds.length,
childJobIds[i]); childJobIds[i]));
} }
} }
@@ -96,7 +96,7 @@ public class AdminBizImpl implements AdminBiz {
} }
// handle msg // handle msg
StringBuffer handleMsg = new StringBuffer(); StringBuilder handleMsg = new StringBuilder();
if (log.getHandleMsg()!=null) { if (log.getHandleMsg()!=null) {
handleMsg.append(log.getHandleMsg()).append("<br>"); handleMsg.append(log.getHandleMsg()).append("<br>");
} }
@@ -108,7 +108,7 @@ public class AdminBizImpl implements AdminBiz {
} }
if (handleMsg.length() > 15000) { if (handleMsg.length() > 15000) {
handleMsg = new StringBuffer(handleMsg.substring(0, 15000)); // text最大64kb 避免长度过长 handleMsg = new StringBuilder(handleMsg.substring(0, 15000)); // text最大64kb 避免长度过长
} }
// success, save log // success, save log
@@ -122,7 +122,7 @@ public class AdminBizImpl implements AdminBiz {
private boolean isNumeric(String str){ private boolean isNumeric(String str){
try { try {
int result = Integer.valueOf(str); Integer.valueOf(str);
return true; return true;
} catch (NumberFormatException e) { } catch (NumberFormatException e) {
return false; return false;
@@ -136,7 +136,7 @@ public class AdminBizImpl implements AdminBiz {
if (!StringUtils.hasText(registryParam.getRegistryGroup()) if (!StringUtils.hasText(registryParam.getRegistryGroup())
|| !StringUtils.hasText(registryParam.getRegistryKey()) || !StringUtils.hasText(registryParam.getRegistryKey())
|| !StringUtils.hasText(registryParam.getRegistryValue())) { || !StringUtils.hasText(registryParam.getRegistryValue())) {
return new ReturnT<String>(ReturnT.FAIL_CODE, "Illegal Argument."); return new ReturnT<>(ReturnT.FAIL_CODE, "Illegal Argument.");
} }
int ret = xxlJobRegistryDao.registryUpdate(registryParam.getRegistryGroup(), registryParam.getRegistryKey(), registryParam.getRegistryValue(), new Date()); int ret = xxlJobRegistryDao.registryUpdate(registryParam.getRegistryGroup(), registryParam.getRegistryKey(), registryParam.getRegistryValue(), new Date());
@@ -156,7 +156,7 @@ public class AdminBizImpl implements AdminBiz {
if (!StringUtils.hasText(registryParam.getRegistryGroup()) if (!StringUtils.hasText(registryParam.getRegistryGroup())
|| !StringUtils.hasText(registryParam.getRegistryKey()) || !StringUtils.hasText(registryParam.getRegistryKey())
|| !StringUtils.hasText(registryParam.getRegistryValue())) { || !StringUtils.hasText(registryParam.getRegistryValue())) {
return new ReturnT<String>(ReturnT.FAIL_CODE, "Illegal Argument."); return new ReturnT<>(ReturnT.FAIL_CODE, "Illegal Argument.");
} }
int ret = xxlJobRegistryDao.registryDelete(registryParam.getRegistryGroup(), registryParam.getRegistryKey(), registryParam.getRegistryValue()); int ret = xxlJobRegistryDao.registryDelete(registryParam.getRegistryGroup(), registryParam.getRegistryKey(), registryParam.getRegistryValue());