diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/service/LoginService.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/service/LoginService.java index e1cf2e44..333e18c9 100644 --- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/service/LoginService.java +++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/service/LoginService.java @@ -28,8 +28,7 @@ public class LoginService { private String makeToken(XxlJobUser xxlJobUser){ String tokenJson = JacksonUtil.writeValueAsString(xxlJobUser); - String tokenHex = new BigInteger(tokenJson.getBytes()).toString(16); - return tokenHex; + return new BigInteger(tokenJson.getBytes()).toString(16); } private XxlJobUser parseToken(String tokenHex){ XxlJobUser xxlJobUser = null; @@ -45,17 +44,17 @@ public class LoginService { // param if (username==null || username.trim().length()==0 || password==null || password.trim().length()==0){ - return new ReturnT(500, I18nUtil.getString("login_param_empty")); + return new ReturnT<>(500, I18nUtil.getString("login_param_empty")); } // valid passowrd XxlJobUser xxlJobUser = xxlJobUserDao.loadByUserName(username); if (xxlJobUser == null) { - return new ReturnT(500, I18nUtil.getString("login_param_unvalid")); + return new ReturnT<>(500, I18nUtil.getString("login_param_unvalid")); } String passwordMd5 = DigestUtils.md5DigestAsHex(password.getBytes()); if (!passwordMd5.equals(xxlJobUser.getPassword())) { - return new ReturnT(500, I18nUtil.getString("login_param_unvalid")); + return new ReturnT<>(500, I18nUtil.getString("login_param_unvalid")); } String loginToken = makeToken(xxlJobUser); @@ -93,11 +92,9 @@ public class LoginService { } if (cookieUser != null) { XxlJobUser dbUser = xxlJobUserDao.loadByUserName(cookieUser.getUsername()); - if (dbUser != null) { - if (cookieUser.getPassword().equals(dbUser.getPassword())) { + if (dbUser != null && cookieUser.getPassword().equals(dbUser.getPassword())) { return dbUser; } - } } } return null;