【fix sonar】 SysAnnouncementSendController.java 文件

This commit is contained in:
tianwenbo
2023-03-03 17:10:28 +08:00
parent eeff9ac909
commit c65ca0929a
@@ -45,6 +45,7 @@ import lombok.extern.slf4j.Slf4j;
public class SysAnnouncementSendController { public class SysAnnouncementSendController {
@Autowired @Autowired
private ISysAnnouncementSendService sysAnnouncementSendService; private ISysAnnouncementSendService sysAnnouncementSendService;
private String ERROE_MSG = "未找到对应实体";
/** /**
* 分页列表查询 * 分页列表查询
@@ -59,9 +60,9 @@ public class SysAnnouncementSendController {
@RequestParam(name="pageNo", defaultValue="1") Integer pageNo, @RequestParam(name="pageNo", defaultValue="1") Integer pageNo,
@RequestParam(name="pageSize", defaultValue="10") Integer pageSize, @RequestParam(name="pageSize", defaultValue="10") Integer pageSize,
HttpServletRequest req) { HttpServletRequest req) {
Result<IPage<SysAnnouncementSend>> result = new Result<IPage<SysAnnouncementSend>>(); Result<IPage<SysAnnouncementSend>> result = new Result<>();
QueryWrapper<SysAnnouncementSend> queryWrapper = new QueryWrapper<SysAnnouncementSend>(sysAnnouncementSend); QueryWrapper<SysAnnouncementSend> queryWrapper = new QueryWrapper<>(sysAnnouncementSend);
Page<SysAnnouncementSend> page = new Page<SysAnnouncementSend>(pageNo,pageSize); Page<SysAnnouncementSend> page = new Page<>(pageNo,pageSize);
//排序逻辑 处理 //排序逻辑 处理
String column = req.getParameter("column"); String column = req.getParameter("column");
String order = req.getParameter("order"); String order = req.getParameter("order");
@@ -107,7 +108,7 @@ public class SysAnnouncementSendController {
public Result<Object> edit(@RequestBody SysAnnouncementSend sysAnnouncementSend) { public Result<Object> edit(@RequestBody SysAnnouncementSend sysAnnouncementSend) {
SysAnnouncementSend sysAnnouncementSendEntity = sysAnnouncementSendService.getById(sysAnnouncementSend.getId()); SysAnnouncementSend sysAnnouncementSendEntity = sysAnnouncementSendService.getById(sysAnnouncementSend.getId());
if(sysAnnouncementSendEntity==null) { if(sysAnnouncementSendEntity==null) {
return Result.error("未找到对应实体"); return Result.error(ERROE_MSG);
}else { }else {
boolean ok = sysAnnouncementSendService.updateById(sysAnnouncementSend); boolean ok = sysAnnouncementSendService.updateById(sysAnnouncementSend);
if(ok) { if(ok) {
@@ -127,7 +128,7 @@ public class SysAnnouncementSendController {
public Result<Object> delete(@RequestParam(name="id",required=true) String id) { public Result<Object> delete(@RequestParam(name="id",required=true) String id) {
SysAnnouncementSend sysAnnouncementSend = sysAnnouncementSendService.getById(id); SysAnnouncementSend sysAnnouncementSend = sysAnnouncementSendService.getById(id);
if(sysAnnouncementSend==null) { if(sysAnnouncementSend==null) {
return Result.error("未找到对应实体"); return Result.error(ERROE_MSG);
}else { }else {
boolean ok = sysAnnouncementSendService.removeById(id); boolean ok = sysAnnouncementSendService.removeById(id);
if(ok) { if(ok) {
@@ -160,10 +161,9 @@ public class SysAnnouncementSendController {
*/ */
@GetMapping(value = "/queryById") @GetMapping(value = "/queryById")
public Result<SysAnnouncementSend> queryById(@RequestParam(name="id",required=true) String id) { public Result<SysAnnouncementSend> queryById(@RequestParam(name="id",required=true) String id) {
Result<SysAnnouncementSend> result = new Result<SysAnnouncementSend>();
SysAnnouncementSend sysAnnouncementSend = sysAnnouncementSendService.getById(id); SysAnnouncementSend sysAnnouncementSend = sysAnnouncementSendService.getById(id);
if(sysAnnouncementSend==null) { if(sysAnnouncementSend==null) {
return Result.error("未找到对应实体"); return Result.error(ERROE_MSG);
}else { }else {
return Result.OK(sysAnnouncementSend); return Result.OK(sysAnnouncementSend);
} }
@@ -176,7 +176,7 @@ public class SysAnnouncementSendController {
*/ */
@PutMapping(value = "/editByAnntIdAndUserId") @PutMapping(value = "/editByAnntIdAndUserId")
public Result<SysAnnouncementSend> editById(@RequestBody JSONObject json) { public Result<SysAnnouncementSend> editById(@RequestBody JSONObject json) {
Result<SysAnnouncementSend> result = new Result<SysAnnouncementSend>(); Result<SysAnnouncementSend> result = new Result<>();
String anntId = json.getString("anntId"); String anntId = json.getString("anntId");
LoginUser sysUser = (LoginUser)SecurityUtils.getSubject().getPrincipal(); LoginUser sysUser = (LoginUser)SecurityUtils.getSubject().getPrincipal();
String userId = sysUser.getId(); String userId = sysUser.getId();
@@ -198,13 +198,13 @@ public class SysAnnouncementSendController {
public Result<IPage<AnnouncementSendModel>> getMyAnnouncementSend(AnnouncementSendModel announcementSendModel, public Result<IPage<AnnouncementSendModel>> getMyAnnouncementSend(AnnouncementSendModel announcementSendModel,
@RequestParam(name="pageNo", defaultValue="1") Integer pageNo, @RequestParam(name="pageNo", defaultValue="1") Integer pageNo,
@RequestParam(name="pageSize", defaultValue="10") Integer pageSize) { @RequestParam(name="pageSize", defaultValue="10") Integer pageSize) {
Result<IPage<AnnouncementSendModel>> result = new Result<IPage<AnnouncementSendModel>>(); Result<IPage<AnnouncementSendModel>> result = new Result<>();
LoginUser sysUser = (LoginUser)SecurityUtils.getSubject().getPrincipal(); LoginUser sysUser = (LoginUser)SecurityUtils.getSubject().getPrincipal();
String userId = sysUser.getId(); String userId = sysUser.getId();
announcementSendModel.setUserId(userId); announcementSendModel.setUserId(userId);
announcementSendModel.setPageNo((pageNo-1)*pageSize); announcementSendModel.setPageNo((pageNo-1)*pageSize);
announcementSendModel.setPageSize(pageSize); announcementSendModel.setPageSize(pageSize);
Page<AnnouncementSendModel> pageList = new Page<AnnouncementSendModel>(pageNo,pageSize); Page<AnnouncementSendModel> pageList = new Page<>(pageNo,pageSize);
pageList = sysAnnouncementSendService.getMyAnnouncementSendPage(pageList, announcementSendModel); pageList = sysAnnouncementSendService.getMyAnnouncementSendPage(pageList, announcementSendModel);
result.setResult(pageList); result.setResult(pageList);
result.setSuccess(true); result.setSuccess(true);