【fix sonar】 SysPermissionDataRuleImpl.java文件

This commit is contained in:
tianwenbo
2023-03-07 11:31:17 +08:00
parent 2a062dc978
commit bce404f0c3
@@ -41,11 +41,11 @@ public class SysPermissionDataRuleImpl extends ServiceImpl<SysPermissionDataRule
*/ */
@Override @Override
public List<SysPermissionDataRule> getPermRuleListByPermId(String permissionId) { public List<SysPermissionDataRule> getPermRuleListByPermId(String permissionId) {
LambdaQueryWrapper<SysPermissionDataRule> query = new LambdaQueryWrapper<SysPermissionDataRule>(); LambdaQueryWrapper<SysPermissionDataRule> query = new LambdaQueryWrapper<>();
query.eq(SysPermissionDataRule::getPermissionId, permissionId); query.eq(SysPermissionDataRule::getPermissionId, permissionId);
query.orderByDesc(SysPermissionDataRule::getCreateTime); query.orderByDesc(SysPermissionDataRule::getCreateTime);
List<SysPermissionDataRule> permRuleList = this.list(query); // List<SysPermissionDataRule> permRuleList = this.list(query);
return permRuleList; return this.list(query);
} }
/** /**
@@ -61,11 +61,11 @@ public class SysPermissionDataRuleImpl extends ServiceImpl<SysPermissionDataRule
public List<SysPermissionDataRule> queryPermissionDataRules(String username,String permissionId) { public List<SysPermissionDataRule> queryPermissionDataRules(String username,String permissionId) {
List<String> idsList = this.baseMapper.queryDataRuleIds(username, permissionId); List<String> idsList = this.baseMapper.queryDataRuleIds(username, permissionId);
//update-begin--Author:scott Date:20191119 for:数据权限失效问题处理-------------------- //update-begin--Author:scott Date:20191119 for:数据权限失效问题处理--------------------
if(idsList==null || idsList.size()==0) { if(idsList==null || idsList.isEmpty()) {
return null; return null;
} }
//update-end--Author:scott Date:20191119 for:数据权限失效问题处理-------------------- //update-end--Author:scott Date:20191119 for:数据权限失效问题处理--------------------
Set<String> set = new HashSet<String>(); Set<String> set = new HashSet<>();
for (String ids : idsList) { for (String ids : idsList) {
if(oConvertUtils.isEmpty(ids)) { if(oConvertUtils.isEmpty(ids)) {
continue; continue;
@@ -77,7 +77,7 @@ public class SysPermissionDataRuleImpl extends ServiceImpl<SysPermissionDataRule
} }
} }
} }
if(set.size()==0) { if(set.isEmpty()) {
return null; return null;
} }
return this.baseMapper.selectList(new QueryWrapper<SysPermissionDataRule>().in("id", set).eq("status",CommonConstant.STATUS_1)); return this.baseMapper.selectList(new QueryWrapper<SysPermissionDataRule>().in("id", set).eq("status",CommonConstant.STATUS_1));