diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java index 748befc6..7e857061 100644 --- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java +++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/trigger/XxlJobTrigger.java @@ -25,6 +25,9 @@ import java.util.Date; public class XxlJobTrigger { private static Logger logger = LoggerFactory.getLogger(XxlJobTrigger.class); + private XxlJobTrigger() { + } + /** * trigger job * @@ -93,7 +96,7 @@ public class XxlJobTrigger { private static boolean isNumeric(String str){ try { - int result = Integer.valueOf(str); + Integer.valueOf(str); return true; } catch (NumberFormatException e) { return false; @@ -155,7 +158,7 @@ public class XxlJobTrigger { } } } else { - routeAddressResult = new ReturnT(ReturnT.FAIL_CODE, I18nUtil.getString("jobconf_trigger_address_empty")); + routeAddressResult = new ReturnT<>(ReturnT.FAIL_CODE, I18nUtil.getString("jobconf_trigger_address_empty")); } // 4、trigger remote executor @@ -163,11 +166,11 @@ public class XxlJobTrigger { if (address != null) { triggerResult = runExecutor(triggerParam, address); } else { - triggerResult = new ReturnT(ReturnT.FAIL_CODE, null); + triggerResult = new ReturnT<>(ReturnT.FAIL_CODE, null); } // 5、collection trigger info - StringBuffer triggerMsgSb = new StringBuffer(); + StringBuilder triggerMsgSb = new StringBuilder(); triggerMsgSb.append(I18nUtil.getString("jobconf_trigger_type")).append(":").append(triggerType.getTitle()); triggerMsgSb.append("
").append(I18nUtil.getString("jobconf_trigger_admin_adress")).append(":").append(IpUtil.getIp()); triggerMsgSb.append("
").append(I18nUtil.getString("jobconf_trigger_exe_regtype")).append(":") @@ -211,10 +214,10 @@ public class XxlJobTrigger { runResult = executorBiz.run(triggerParam); } catch (Exception e) { logger.error(">>>>>>>>>>> xxl-job trigger error, please check if the executor[{}] is running.", address, e); - runResult = new ReturnT(ReturnT.FAIL_CODE, ThrowableUtil.toString(e)); + runResult = new ReturnT<>(ReturnT.FAIL_CODE, ThrowableUtil.toString(e)); } - StringBuffer runResultSB = new StringBuffer(I18nUtil.getString("jobconf_trigger_run") + ":"); + StringBuilder runResultSB = new StringBuilder(I18nUtil.getString("jobconf_trigger_run") + ":"); runResultSB.append("
address:").append(address); runResultSB.append("
code:").append(runResult.getCode()); runResultSB.append("
msg:").append(runResult.getMsg());