From 703c42c93611536f15607afa38f2e5b63998d1b9 Mon Sep 17 00:00:00 2001 From: tianwenbo Date: Fri, 10 Mar 2023 16:17:46 +0800 Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91=20JobLogReportHel?= =?UTF-8?q?per.java=E6=96=87=E4=BB=B6?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../xxl/job/admin/core/thread/JobLogReportHelper.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLogReportHelper.java b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLogReportHelper.java index 2387a0c4..7dcce347 100644 --- a/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLogReportHelper.java +++ b/jero-boot/jero-cloud-module/jero-cloud-xxljob/src/main/java/com/xxl/job/admin/core/thread/JobLogReportHelper.java @@ -28,10 +28,7 @@ public class JobLogReportHelper { private Thread logrThread; private volatile boolean toStop = false; public void start(){ - logrThread = new Thread(new Runnable() { - - @Override - public void run() { + logrThread = new Thread(()-> { // last clean log time long lastCleanLogTime = 0; @@ -110,10 +107,10 @@ public class JobLogReportHelper { List logIds = null; do { logIds = XxlJobAdminConfig.getAdminConfig().getXxlJobLogDao().findClearLogIds(0, 0, clearBeforeTime, 0, 1000); - if (logIds!=null && logIds.size()>0) { + if (logIds!=null && !logIds.isEmpty()) { XxlJobAdminConfig.getAdminConfig().getXxlJobLogDao().clearLog(logIds); } - } while (logIds!=null && logIds.size()>0); + } while (logIds!=null && !logIds.isEmpty()); // update clean time lastCleanLogTime = System.currentTimeMillis(); @@ -130,8 +127,6 @@ public class JobLogReportHelper { } logger.info(">>>>>>>>>>> xxl-job, job log report thread stop"); - - } }); logrThread.setDaemon(true); logrThread.setName("xxl-job, admin JobLogReportHelper");