【fix sonar】SysPermissionServiceImpl文件

This commit is contained in:
梁琦涛
2023-03-10 15:27:32 +08:00
parent 0ac5586bfc
commit 5365769a47
@@ -1,12 +1,8 @@
package com.jero.modules.system.service.impl; package com.jero.modules.system.service.impl;
import java.util.Date; import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import java.util.HashMap; import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import java.util.List; import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
import java.util.Map;
import javax.annotation.Resource;
import com.jero.common.constant.CacheConstant; import com.jero.common.constant.CacheConstant;
import com.jero.common.constant.CommonConstant; import com.jero.common.constant.CommonConstant;
import com.jero.common.exception.JeroBootException; import com.jero.common.exception.JeroBootException;
@@ -24,9 +20,11 @@ import org.springframework.cache.annotation.Cacheable;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional; import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper; import javax.annotation.Resource;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper; import java.util.Date;
import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl; import java.util.HashMap;
import java.util.List;
import java.util.Map;
/** /**
* <p> * <p>
@@ -62,7 +60,7 @@ public class SysPermissionServiceImpl extends ServiceImpl<SysPermissionMapper, S
* 真实删除 * 真实删除
*/ */
@Override @Override
@Transactional @Transactional(rollbackFor = JeroBootException.class)
@CacheEvict(value = CacheConstant.SYS_DATA_PERMISSIONS_CACHE,allEntries=true) @CacheEvict(value = CacheConstant.SYS_DATA_PERMISSIONS_CACHE,allEntries=true)
public void deletePermission(String id) throws JeroBootException { public void deletePermission(String id) throws JeroBootException {
SysPermission sysPermission = this.getById(id); SysPermission sysPermission = this.getById(id);
@@ -81,7 +79,7 @@ public class SysPermissionServiceImpl extends ServiceImpl<SysPermissionMapper, S
// 该节点可能是子节点但也可能是其它节点的父节点,所以需要级联删除 // 该节点可能是子节点但也可能是其它节点的父节点,所以需要级联删除
this.removeChildrenBy(sysPermission.getId()); this.removeChildrenBy(sysPermission.getId());
//关联删除 //关联删除
Map map = new HashMap<>(); Map<String,Object> map = new HashMap<>();
map.put("permission_id",id); map.put("permission_id",id);
//删除数据规则 //删除数据规则
this.deletePermRuleByPermId(id); this.deletePermRuleByPermId(id);
@@ -110,7 +108,7 @@ public class SysPermissionServiceImpl extends ServiceImpl<SysPermissionMapper, S
// 再遍历刚才查出的集合, 根据每个对象,查找其是否仍有子级 // 再遍历刚才查出的集合, 根据每个对象,查找其是否仍有子级
for (int i = 0, len = permissionList.size(); i < len; i++) { for (int i = 0, len = permissionList.size(); i < len; i++) {
id = permissionList.get(i).getId(); id = permissionList.get(i).getId();
Map map = new HashMap<>(); Map<String,Object> map = new HashMap<>();
map.put("permission_id",id); map.put("permission_id",id);
//删除数据规则 //删除数据规则
this.deletePermRuleByPermId(id); this.deletePermRuleByPermId(id);