From 1175ba0d57907ddc091669c8ea2eb3298cb5d225 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=A2=81=E7=90=A6=E6=B6=9B?= <liangqitao@syxysoft.com>
Date: Wed, 8 Mar 2023 16:11:36 +0800
Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91CASServiceUtil?=
 =?UTF-8?q?=E6=96=87=E4=BB=B6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../jero/modules/cas/util/CASServiceUtil.java | 31 ++++++++++++-------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/cas/util/CASServiceUtil.java b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/cas/util/CASServiceUtil.java
index b7bead1e..2d3b0b73 100644
--- a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/cas/util/CASServiceUtil.java
+++ b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/cas/util/CASServiceUtil.java
@@ -1,14 +1,6 @@
 package com.jero.modules.cas.util;
 
-import java.io.BufferedReader;
-import java.io.IOException;
-import java.io.InputStreamReader;
-import java.security.cert.X509Certificate;
-
-import javax.net.ssl.SSLContext;
-import javax.net.ssl.TrustManager;
-import javax.net.ssl.X509TrustManager;
-
+import lombok.extern.slf4j.Slf4j;
 import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.conn.socket.LayeredConnectionSocketFactory;
@@ -16,15 +8,28 @@ import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
 import org.apache.http.impl.client.CloseableHttpClient;
 import org.apache.http.impl.client.HttpClients;
 
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.X509TrustManager;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStreamReader;
+import java.security.cert.X509Certificate;
+
+@Slf4j
 public class CASServiceUtil {
 
+    private CASServiceUtil(){
+
+    }
+
 	public static void main(String[] args) {
 		String serviceUrl = "https://cas.8f8.com.cn:8443/cas/p3/serviceValidate";
 		String service = "http://localhost:3003/user/login";
 		String ticket = "ST-5-1g-9cNES6KXNRwq-GuRET103sm0-DESKTOP-VKLS8B3";
 		String res = getSTValidate(serviceUrl,ticket, service);
 
-		System.out.println("---------res-----"+res);
+		log.info("---------res-----"+res);
 	}
 
 
@@ -38,7 +43,7 @@ public class CASServiceUtil {
 			HttpGet httpget = new HttpGet(url);
 			HttpResponse response = httpclient.execute(httpget);
 	        String res = readResponse(response);
-	        return res == null ? null : ("".equals(res) ? null : res);
+            return "".equals(res) ? null : res;
 		} catch (Exception e) {
 			e.printStackTrace();
 		}
@@ -77,17 +82,19 @@ public class CASServiceUtil {
                 new X509TrustManager() {
                     @Override
                     public X509Certificate[] getAcceptedIssuers() {
-                        return null;
+                        return new X509Certificate[0];
                     }
 
                     @Override
                     public void checkClientTrusted(X509Certificate[] certs, String authType) {
                         // don't check
+                        log.info("client");
                     }
 
                     @Override
                     public void checkServerTrusted(X509Certificate[] certs, String authType) {
                         // don't check
+                        log.info("server");
                     }
                 }
         };