From 0ab5d270be802ef5a0307cfc33126437fb8866b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=A2=81=E7=90=A6=E6=B6=9B?= <liangqitao@syxysoft.com>
Date: Fri, 10 Mar 2023 15:03:31 +0800
Subject: [PATCH] =?UTF-8?q?=E3=80=90fix=20sonar=E3=80=91LoginServiceImpl?=
 =?UTF-8?q?=E6=96=87=E4=BB=B6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../system/service/impl/LoginServiceImpl.java | 25 +++++++++++--------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/system/service/impl/LoginServiceImpl.java b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/system/service/impl/LoginServiceImpl.java
index 5542bc0b..d24a007e 100644
--- a/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/system/service/impl/LoginServiceImpl.java
+++ b/jero-boot/jero-boot-module-system/src/main/java/com/jero/modules/system/service/impl/LoginServiceImpl.java
@@ -285,17 +285,8 @@ public class LoginServiceImpl implements ILoginService {
                     }
                     return result;
                 }
+                b = smsMode(mobile, smsmode, obj, b);
 
-                /**
-                 * smsmode 短信模板方式  0 .登录模板、1.注册模板、2.忘记密码模板
-                 */
-                if (CommonConstant.SMS_TPL_TYPE_0.equals(smsmode)) {
-                    //登录模板
-                    b = DySmsHelper.sendSms(mobile, obj, DySmsEnum.LOGIN_TEMPLATE_CODE);
-                } else if(CommonConstant.SMS_TPL_TYPE_2.equals(smsmode)) {
-                    //忘记密码模板
-                    b = DySmsHelper.sendSms(mobile, obj, DySmsEnum.FORGET_PASSWORD_TEMPLATE_CODE);
-                }
             }
 
             if (!b) {
@@ -317,6 +308,20 @@ public class LoginServiceImpl implements ILoginService {
         return result;
     }
 
+    private boolean smsMode(String mobile, String smsmode, JSONObject obj, boolean b) throws ClientException {
+        /**
+         * smsmode 短信模板方式  0 .登录模板、1.注册模板、2.忘记密码模板
+         */
+        if (CommonConstant.SMS_TPL_TYPE_0.equals(smsmode)) {
+            //登录模板
+            b = DySmsHelper.sendSms(mobile, obj, DySmsEnum.LOGIN_TEMPLATE_CODE);
+        } else if(CommonConstant.SMS_TPL_TYPE_2.equals(smsmode)) {
+            //忘记密码模板
+            b = DySmsHelper.sendSms(mobile, obj, DySmsEnum.FORGET_PASSWORD_TEMPLATE_CODE);
+        }
+        return b;
+    }
+
     @Override
     public Result<JSONObject> phoneLogin(JSONObject jsonObject) {
         Result<JSONObject> result ;